Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: title selection - WPB-11344 #2038

Open
wants to merge 1 commit into
base: epic/navigation-overhaul-WPB-6647
Choose a base branch
from

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Oct 16, 2024

BugWPB-11344 [iPad] Set the filter name as the second panel title

Issue

This updates the title of the conversations list from "All conversations" to "All" on iPad.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added echoes: features End-user visible changes intended to create customer value echoes: technical-debt Changes intended at mitigating risks labels Oct 16, 2024
@netbe netbe changed the base branch from develop to epic/navigation-overhaul-WPB-6647 October 16, 2024 06:47
Copy link
Contributor

Test Results

    1 files    289 suites   2m 13s ⏱️
1 792 tests 1 780 ✅ 0 💤 12 ❌
1 804 runs  1 780 ✅ 0 💤 24 ❌

For more details on these failures, see this check.

Results for commit 38d79b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value echoes: technical-debt Changes intended at mitigating risks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant